Skip to content

fix(amazonq): fix Inline completion acceptance and reject telemetry race condition #7734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2025
Merged

fix(amazonq): fix Inline completion acceptance and reject telemetry race condition #7734

merged 2 commits into from
Jul 23, 2025

Conversation

@leigaol
Copy link
Contributor

@leigaol leigaol commented Jul 23, 2025 •
edited
Loading

Problem

When Q is editing (on accept, on reject is in progress), if we trigger again, the session is not closed yet, global state varaibles are still in progress to be cleared, and we will report wrong user trigger decision telemetry. This is worse for acceptance since it has a await sleep for diagnostics to update.

Solution

Do not let it trigger when Q is editing!

This is not customer facing so no change log.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested a review from a team as a code owner July 23, 2025 04:36
@github-actions
Copy link

github-actions bot commented Jul 23, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@leigaol leigaol changed the title fix(amazonq): fix Inline completion acceptance and reject race condition fix(amazonq): fix Inline completion acceptance and reject telemetry race condition Jul 23, 2025
@leigaol
Copy link
Contributor Author

leigaol commented Jul 23, 2025

unit test failure is not relevant to this pr

@leigaol leigaol merged commit b980406 into aws:master Jul 23, 2025
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Will-ShaoHua Will-ShaoHua Will-ShaoHua approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leigaol @Will-ShaoHua